Skip to content

8358748: Large page size initialization fails with assert "page_size must be a power of 2" #2397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

8358748: Large page size initialization fails with assert "page_size must be a power of 2" #2397

wants to merge 2 commits into from

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Oct 25, 2025 •
edited by openjdk bot
Loading

I backport this for parity with 21.0.10-oracle

Needed resolves. In the code due to context.
The test had an other flag it tests, I could have kept that
but I thought it's better to use the one from this change.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8358748 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8358748: Large page size initialization fails with assert "page_size must be a power of 2" (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2397/head:pull/2397
$ git checkout pull/2397

Update a local copy of the PR:
$ git checkout pull/2397
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2397/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2397

View PR using the GUI difftool:
$ git pr show -t 2397

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2397.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 25, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 25, 2025 •
edited
Loading

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8358748: Large page size initialization fails with assert "page_size must be a power of 2"

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@GoeLin GoeLin changed the title backport 40bc083267c0bac64b1092c63325b8d245937b0 backport 40bc083267c0bac64b1092c63325b8d245937b0e Oct 25, 2025
@openjdk openjdk bot changed the title backport 40bc083267c0bac64b1092c63325b8d245937b0e 8358748: Large page size initialization fails with assert "page_size must be a power of 2" Oct 25, 2025
@openjdk
Copy link

openjdk bot commented Oct 25, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Oct 25, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 25, 2025 •
edited
Loading

Webrevs

TheRealMDoerr
TheRealMDoerr reviewed Oct 27, 2025
View reviewed changes
test/lib-test/jdk/test/whitebox/vm_flags/SizeTTest.java Outdated
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* ANY WARRANTY; without even the implied warranty of MERCHANTABILTY or
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this was changed by mistake. Otherwise, the backport LGTM.

Copy link
Member Author

@GoeLin GoeLin Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Thanks for the review.

@GoeLin
Copy link
Member Author

GoeLin commented Oct 27, 2025

Oh, I should not have backported this with AI :P

Sorry, yes, a typ-o.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Oct 27, 2025
@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Oct 28, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Oct 28, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Oct 28, 2025

Going to push as commit 870438e.
Since your change was applied there have been 16 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 28, 2025
@openjdk openjdk bot closed this Oct 28, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 28, 2025
@openjdk
Copy link

openjdk bot commented Oct 28, 2025

@GoeLin Pushed as commit 870438e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8358748 branch October 28, 2025 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@TheRealMDoerr TheRealMDoerr TheRealMDoerr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport Port of a pull request already in a different code base integrated Pull request has been integrated

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GoeLin @TheRealMDoerr